• Yoshihiro Shimoda's avatar
    phy: rcar-gen3-usb2: fix unexpected repeat interrupts of VBUS change · 6762925d
    Yoshihiro Shimoda authored
    This patch fixes an issue that the driver is possible to cause
    unexpected repeat interrupts if a board condition is wrong
    (e.g. even if the ID pin is as function, a board supplies the VBUS.)
    
    The reason why unexpected repeat interrupts happen is:
     1) The driver changed the mode to function if it detected the ID pin
        is high and the VBUS is high.
     2) After the driver changed function mode, it disabled the "VBUS control"
        feature. Then, the VBUS signal will be low.
     3) Since the VBUS change interruption happened, the driver checked
        the ID pin and VBUS.
     4) Since VBUS was low, the driver changed the mode to host and enabled
        the "VBUS control" feature. Then the VBUS signal will be high.
     5) Since the VBUS change interruption happened, the driver did 1) above.
    
    So, this patch modified the condition in rcar_gen3_device_recognition()
    to check the ID pin only.
    
    Fixes: 1114e2d3 (phy: rcar-gen3-usb2: change the mode to OTG on the combined channel)
    Cc: <stable@vger.kernel.org> # v4.5+
    Reported-by: default avatarSimon Horman <horms@verge.net.au>
    Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
    6762925d
phy-rcar-gen3-usb2.c 9.34 KB