• Mårten Lindahl's avatar
    pwm: pwm-samsung: Trigger manual update when disabling PWM · 5d82e661
    Mårten Lindahl authored
    When duty-cycle is at full level (100%), the TCNTn and TCMPn registers
    needs to be flushed in order to disable the signal. The PWM manual does
    not say anything about this, but states that only clearing the TCON
    auto-reload bit should be needed, and this seems to be true when the PWM
    duty-cycle is not at full level. This can be observed on an Axis
    ARTPEC-8, by running:
    
      echo <period> > pwm/period
      echo <period> > pwm/duty_cycle
      echo 1 > pwm/enable
      echo 0 > pwm/enable
    
    Since the TCNTn and TCMPn registers are activated when enabling the PWM
    (setting TCON auto-reload bit), and are not touched when disabling the
    PWM, the double buffered auto-reload function seems to be still active.
    Lowering duty-cycle, and restoring it again in between the enabling and
    disabling, makes the disable work since it triggers a reload of the
    TCNTn and TCMPn registers.
    
    Fix this by securing a reload of the TCNTn and TCMPn registers when
    disabling the PWM and having a full duty-cycle.
    Signed-off-by: default avatarMårten Lindahl <marten.lindahl@axis.com>
    Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
    5d82e661
pwm-samsung.c 17.1 KB