• Kirill Tkhai's avatar
    mac80211_hwsim: Make hwsim_netgroup IDA · 03695549
    Kirill Tkhai authored
    hwsim_netgroup counter is declarated as int, and it is incremented
    every time a new net is created. After sizeof(int) net are created,
    it will overflow, and different net namespaces will have the same
    identifier. This patch fixes the problem by introducing IDA instead
    of int counter. IDA guarantees, all the net namespaces have the uniq
    identifier.
    
    Note, that after we do ida_simple_remove() in hwsim_exit_net(),
    and we destroy the ID, later there may be executed destroy_radio()
    from the workqueue. But destroy_radio() does not use the ID, so it's OK.
    
    Out of bounds of this patch, just as a report to wireless subsystem
    maintainer, destroy_radio() increaments hwsim_radios_generation
    without hwsim_radio_lock, so this may need one more patch to fix.
    Signed-off-by: default avatarKirill Tkhai <ktkhai@virtuozzo.com>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    03695549
mac80211_hwsim.c 98.6 KB