• Ross Zwisler's avatar
    ext2: remove support for DAX PMD faults · 03e0990f
    Ross Zwisler authored
    DAX PMD support was added via the following commit:
    
    commit e7b1ea2a ("ext2: huge page fault support")
    
    I believe this path to be untested as ext2 doesn't reliably provide block
    allocations that are aligned to 2MiB.  In my testing I've been unable to
    get ext2 to actually fault in a PMD.  It always fails with a "pfn
    unaligned" message because the sector returned by ext2_get_block() isn't
    aligned.
    
    I've tried various settings for the "stride" and "stripe_width" extended
    options to mkfs.ext2, without any luck.
    
    Since we can't reliably get PMDs, remove support so that we don't have an
    untested code path that we may someday traverse when we happen to get an
    aligned block allocation.  This should also make 4k DAX faults in ext2 a
    bit faster since they will no longer have to call the PMD fault handler
    only to get a response of VM_FAULT_FALLBACK.
    Signed-off-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    03e0990f
file.c 5.86 KB