• Arnd Bergmann's avatar
    chelsio: use BUG() instead of BUG_ON(1) · 047a013f
    Arnd Bergmann authored
    clang warns about possible bugs in a dead code branch after
    BUG_ON(1) when CONFIG_PROFILE_ALL_BRANCHES is enabled:
    
     drivers/net/ethernet/chelsio/cxgb4/sge.c:479:3: error: variable 'buf_size' is used uninitialized whenever 'if'
          condition is false [-Werror,-Wsometimes-uninitialized]
                    BUG_ON(1);
                    ^~~~~~~~~
     include/asm-generic/bug.h:61:36: note: expanded from macro 'BUG_ON'
     #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
                                       ^~~~~~~~~~~~~~~~~~~
     include/linux/compiler.h:48:23: note: expanded from macro 'unlikely'
     #  define unlikely(x)   (__branch_check__(x, 0, __builtin_constant_p(x)))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     drivers/net/ethernet/chelsio/cxgb4/sge.c:482:9: note: uninitialized use occurs here
            return buf_size;
                   ^~~~~~~~
     drivers/net/ethernet/chelsio/cxgb4/sge.c:479:3: note: remove the 'if' if its condition is always true
                    BUG_ON(1);
                    ^
     include/asm-generic/bug.h:61:32: note: expanded from macro 'BUG_ON'
     #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
                                   ^
     drivers/net/ethernet/chelsio/cxgb4/sge.c:459:14: note: initialize the variable 'buf_size' to silence this warning
            int buf_size;
                        ^
                         = 0
    
    Use BUG() here to create simpler code that clang understands
    correctly.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    047a013f
sge.c 125 KB