• Tuong Lien's avatar
    Revert "tipc: Fix potential tipc_node refcnt leak in tipc_rcv" · 049fa17f
    Tuong Lien authored
    This reverts commit de058420.
    
    There is no actual tipc_node refcnt leak as stated in the above commit.
    The refcnt is hold carefully for the case of an asynchronous decryption
    (i.e. -EINPROGRESS/-EBUSY and skb = NULL is returned), so that the node
    object cannot be freed in the meantime. The counter will be re-balanced
    when the operation's callback arrives with the decrypted buffer if any.
    In other cases, e.g. a synchronous crypto the counter will be decreased
    immediately when it is done.
    
    Now with that commit, a kernel panic will occur when there is no node
    found (i.e. n = NULL) in the 'tipc_rcv()' or a premature release of the
    node object.
    
    This commit solves the issues by reverting the said commit, but keeping
    one valid case that the 'skb_linearize()' is failed.
    Acked-by: default avatarJon Maloy <jmaloy@redhat.com>
    Signed-off-by: default avatarTuong Lien <tuong.t.lien@dektech.com.au>
    Tested-by: default avatarHoang Le <hoang.h.le@dektech.com.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    049fa17f
node.c 75.5 KB