• Olaf Hering's avatar
    xen/pv-on-hvm kexec: add xs_reset_watches to shutdown watches from old kernel · ddacf5ef
    Olaf Hering authored
    Add new xs_reset_watches function to shutdown watches from old kernel after
    kexec boot.  The old kernel does not unregister all watches in the
    shutdown path.  They are still active, the double registration can not
    be detected by the new kernel.  When the watches fire, unexpected events
    will arrive and the xenwatch thread will crash (jumps to NULL).  An
    orderly reboot of a hvm guest will destroy the entire guest with all its
    resources (including the watches) before it is rebuilt from scratch, so
    the missing unregister is not an issue in that case.
    
    With this change the xenstored is instructed to wipe all active watches
    for the guest.  However, a patch for xenstored is required so that it
    accepts the XS_RESET_WATCHES request from a client (see changeset
    23839:42a45baf037d in xen-unstable.hg). Without the patch for xenstored
    the registration of watches will fail and some features of a PVonHVM
    guest are not available. The guest is still able to boot, but repeated
    kexec boots will fail.
    
    [v5: use xs_single instead of passing a dummy string to xs_talkv]
    [v4: ignore -EEXIST in xs_reset_watches]
    [v3: use XS_RESET_WATCHES instead of XS_INTRODUCE]
    [v2: move all code which deals with XS_INTRODUCE into xs_introduce()
        (based on feedback from Ian Campbell); remove casts from kvec assignment]
    Signed-off-by: default avatarOlaf Hering <olaf@aepfle.de>
    [v1: Redid the git description a bit]
    Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    ddacf5ef
xs_wire.h 2.08 KB