• Quentin Monnet's avatar
    bpftool: Turn check on zlib from a phony target into a conditional error · 062e1fc0
    Quentin Monnet authored
    One of bpftool's object files depends on zlib. To make sure we do not
    attempt to build that object when the library is not available, commit
    d66fa3c7 ("tools: bpftool: add feature check for zlib") introduced a
    feature check to detect whether zlib is present.
    
    This check comes as a rule for which the target ("zdep") is a
    nonexistent file (phony target), which means that the Makefile always
    attempts to rebuild it. It is mostly harmless. However, one side effect
    is that, on running again once bpftool is already built, make considers
    that "something" (the recipe for zdep) was executed, and does not print
    the usual message "make: Nothing to be done for 'all'", which is a
    user-friendly indicator that the build went fine.
    
    Before, with some level of debugging information:
    
        $ make --debug=m
        [...]
        Reading makefiles...
    
        Auto-detecting system features:
        ...                        libbfd: [ on  ]
        ...        disassembler-four-args: [ on  ]
        ...                          zlib: [ on  ]
        ...                        libcap: [ on  ]
        ...               clang-bpf-co-re: [ on  ]
    
        Updating makefiles....
        Updating goal targets....
         File 'all' does not exist.
               File 'zdep' does not exist.
              Must remake target 'zdep'.
         File 'all' does not exist.
        Must remake target 'all'.
        Successfully remade target file 'all'.
    
    After the patch:
    
        $ make --debug=m
        [...]
    
        Auto-detecting system features:
        ...                        libbfd: [ on  ]
        ...        disassembler-four-args: [ on  ]
        ...                          zlib: [ on  ]
        ...                        libcap: [ on  ]
        ...               clang-bpf-co-re: [ on  ]
    
        Updating makefiles....
        Updating goal targets....
         File 'all' does not exist.
        Must remake target 'all'.
        Successfully remade target file 'all'.
        make: Nothing to be done for 'all'.
    
    (Note the last line, which is not part of make's debug information.)
    Signed-off-by: default avatarQuentin Monnet <quentin@isovalent.com>
    Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
    Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
    Link: https://lore.kernel.org/bpf/20211009210341.6291-4-quentin@isovalent.com
    062e1fc0
Makefile 7.28 KB