• Gustavo A. R. Silva's avatar
    wireless: airo: remove unnecessary static in writerids() · 06548fbb
    Gustavo A. R. Silva authored
    Remove unnecessary static on local function pointer _writer_.
    Such pointer is initialized before being used, on every
    execution path throughout the function. The static has no
    benefit and, removing it reduces the object file size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see a significant difference in the object
    file size. This log is the output of the size command, before and after
    the code change:
    
    before:
       text    data     bss     dec     hex filename
     113797   19152    1216  134165   20c15 drivers/net/wireless/cisco/airo.o
    
    after:
       text	   data	    bss	    dec	    hex	filename
     113881	  19096	   1152	 134129	  20bf1	drivers/net/wireless/cisco/airo.o
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    06548fbb
airo.c 218 KB