• Jiri Slaby's avatar
    x86, printk: Get rid of <0> from stack output · e4072a9a
    Jiri Slaby authored
    The stack output currently looks like this:
    
     7fffffffffffffff 0000000a00000000 ffffffff81093341 0000000000000046
    <0> ffff88003a545fd8 0000000000000000 0000000000000000 00007fffa39769c0
    <0> ffff88003e403f58 ffffffff8102fc4c ffff88003e403f58 ffff88003e403f78
    
    The superfluous <0> are caused by recent printk KERN_CONT
    change. <*> is now ignored in printk unless some text follows
    the level and even then it still has to be the first in the
    format message.
    
    Note that the log_lvl parameter is now completely ignored in
    show_stack_log_lvl and the stack is dumped with the default
    level (like for quite some time already). It behaves the same as
    the rest of the dump, function traces are dumped in the very
    same manner. Only Code and maybe some lines are printed with
    EMERG level.
    
    Unfortunately I see no way how to fix this conceptually to have
    the whole oops/BUG/panic output with the same level, so this
    removed only the superfluous characters for the time being.
    
    Just for illustration:
    
    <4>Process kworker/0:0 (pid: 0, threadinfo ffff88003c8a6000, task ffff88003c85c100)
    <0>Stack:
    <4> ffffffff818022c0 0000000a00000001 0000000000000001 0000000000000046
    <4> ffff88003c8a7fd8 0000000000000001 ffff88003c8a7e58 0000000000000000
    <4> ffff88003e503f48 ffffffff8102fc4c ffff88003e503f48 ffff88003e503f68
    <0>Call Trace:
    <0> <IRQ>
    <4> [<ffffffff8102fc4c>] ? call_softirq+0x1c/0x30 ...
    <0>Code: 00 01 00 00 65 8b 04 25 80 c5 00 00 c7 45 ...
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    Cc: jirislaby@gmail.com
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    LKML-Reference: <1287586131-16222-1-git-send-email-jslaby@suse.cz>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    e4072a9a
dumpstack_32.c 3.21 KB