• Long Li's avatar
    xfs: add lock protection when remove perag from radix tree · 07afd317
    Long Li authored
    Take mp->m_perag_lock for deletions from the perag radix tree in
    xfs_initialize_perag to prevent racing with tagging operations.
    Lookups are fine - they are RCU protected so already deal with the
    tree changing shape underneath the lookup - but tagging operations
    require the tree to be stable while the tags are propagated back up
    to the root.
    
    Right now there's nothing stopping radix tree tagging from operating
    while a growfs operation is progress and adding/removing new entries
    into the radix tree.
    
    Hence we can have traversals that require a stable tree occurring at
    the same time we are removing unused entries from the radix tree which
    causes the shape of the tree to change.
    
    Likely this hasn't caused a problem in the past because we are only
    doing append addition and removal so the active AG part of the tree
    is not changing shape, but that doesn't mean it is safe. Just making
    the radix tree modifications serialise against each other is obviously
    correct.
    Signed-off-by: default avatarLong Li <leo.lilong@huawei.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
    Signed-off-by: default avatarChandan Babu R <chandanbabu@kernel.org>
    07afd317
xfs_ag.c 27.9 KB