• Krzysztof Kosiński's avatar
    tc1100-wmi: Fix state reporting · 07de5bdb
    Krzysztof Kosiński authored
    The tc1100-wmi driver should print the current states of wireless LAN and
    jogdial brightness control when "cat /sys/devices/platform/tc1100-wmi/wireless"
    and "cat /sys/devices/platform/tc1100-wmi/jogdial" are executed, respectively.
    What actually happens is that both of those commands print 0 regardless of the
    hardware state. The cause is that wmi_query_block returns an ACPI_TYPE_INTEGER
    rather than ACPI_TYPE_BUFFER as the driver assumes. Additionally, the driver
    intends to return a jogdial state that is inverted with respect to the commands
    required to set it (e.g. it intends to return 1 after the jogdial file was
    written with 0).
    
    This patch fixes both of those issues - the commands to query the
    state now work, and should return the same state that was written.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=12286Signed-off-by: default avatarKrzysztof Kosiński <tweenk.pl@gmail.com>
    Acked-by: default avatarCarlos Corbacho <carlos@strangeworlds.co.uk>
    Signed-off-by: default avatarLen Brown <len.brown@intel.com>
    07de5bdb
tc1100-wmi.c 6.78 KB