• Neil Brown's avatar
    [PATCH] nfsd: simplify auth_domain_lookup · 086aa2c5
    Neil Brown authored
    The interface between the auth_domain and the cache code is messy; the
    auth_domain code is the only real user of the full 11-argument
    DefineCacheLookup, and does weird stuff with it (like passing in through one
    of the arguments a bit of code with a conditional return).
    
    We could further parametrize DefineCacheLookup, but I think it's already too
    complicated.
    
    My solution is to just ignore DefineCacheLookup and write the
    auth_domain_lookup function from scratch.  It's actually a pretty short
    function (much simpler than DefineCacheLookup itself), and it's much easier to
    read this short function than it is to read some special-cased
    DefineCacheLookup to verify that it does what it says it does....
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    Signed-off-by: default avatarNeil Brown <neilb@cse.unsw.edu.au>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    086aa2c5
svcauth.c 5.12 KB