• Daniel Vetter's avatar
    drm/i915: rework locking for intel_dpio|sbi_read|write · 09153000
    Daniel Vetter authored
    Spinning for up to 200 us with interrupts locked out is not good. So
    let's just spin (and even that seems to be excessive).
    
    And we don't call these functions from interrupt context, so this is
    not required. Besides that doing anything in interrupt contexts which
    might take a few hundred us is a no-go. So just convert the entire
    thing to a mutex. Also move the mutex-grabbing out of the read/write
    functions (add a WARN_ON(!is_locked)) instead) since all callers are
    nicely grouped together.
    
    Finally the real motivation for this change: Dont grab the modeset
    mutex in the dpio debugfs file, we don't need that consistency. And
    correctness of the dpio interface is ensured with the dpio_lock.
    Reviewed-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    09153000
i915_debugfs.c 58.6 KB