• Paolo Bonzini's avatar
    KVM: check userspace_addr for all memslots · 09d952c9
    Paolo Bonzini authored
    The userspace_addr alignment and range checks are not performed for private
    memory slots that are prepared by KVM itself.  This is unnecessary and makes
    it questionable to use __*_user functions to access memory later on.  We also
    rely on the userspace address being aligned since we have an entire family
    of functions to map gfn to pfn.
    
    Fortunately skipping the check is completely unnecessary.  Only x86 uses
    private memslots and their userspace_addr is obtained from vm_mmap,
    therefore it must be below PAGE_OFFSET.  In fact, any attempt to pass
    an address above PAGE_OFFSET would have failed because such an address
    would return true for kvm_is_error_hva.
    Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    09d952c9
kvm_main.c 118 KB