• Johannes Berg's avatar
    mac80211: fix locking in ieee80211_sta_tear_down_BA_sessions · 0afe9d4a
    Johannes Berg authored
    Due to overlap between
    commit 12811037 ("mac80211: Simplify locking in ieee80211_sta_tear_down_BA_sessions()")
    and the way that Luca modified
    commit 72e2c343 ("mac80211: tear down RX aggregations first")
    when sending it upstream from Intel's internal tree, we get
    the following warning:
    
    WARNING: CPU: 0 PID: 5472 at net/mac80211/agg-tx.c:315 ___ieee80211_stop_tx_ba_session+0x158/0x1f0
    
    since there's no appropriate locking around the call to
    ___ieee80211_stop_tx_ba_session; Sara's original just had
    a call to the locked __ieee80211_stop_tx_ba_session (one
    less underscore) but it looks like Luca modified both of
    the calls when fixing it up for upstream, leading to the
    problem at hand.
    
    Move the locking appropriately to fix this problem.
    Reported-by: default avatarKalle Valo <kvalo@codeaurora.org>
    Reported-by: default avatarPavel Machek <pavel@ucw.cz>
    Tested-by: default avatarPavel Machek <pavel@ucw.cz>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    0afe9d4a
ht.c 16.8 KB