• Nadav Amit's avatar
    x86/mm/tlb: Remove 'struct flush_tlb_info' from the stack · 3db6d5a5
    Nadav Amit authored
    Move flush_tlb_info variables off the stack. This allows to align
    flush_tlb_info to cache-line and avoid potentially unnecessary cache
    line movements. It also allows to have a fixed virtual-to-physical
    translation of the variables, which reduces TLB misses.
    
    Use per-CPU struct for flush_tlb_mm_range() and
    flush_tlb_kernel_range(). Add debug assertions to ensure there are
    no nested TLB flushes that might overwrite the per-CPU data. For
    arch_tlbbatch_flush() use a const struct.
    
    Results when running a microbenchmarks that performs 10^6 MADV_DONTEED
    operations and touching a page, in which 3 additional threads run a
    busy-wait loop (5 runs, PTI and retpolines are turned off):
    
    			base		off-stack
    			----		---------
      avg (usec/op)		1.629		1.570	(-3%)
      stddev		0.014		0.009
    Signed-off-by: default avatarNadav Amit <namit@vmware.com>
    Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Dave Hansen <dave.hansen@intel.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/20190425230143.7008-1-namit@vmware.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    3db6d5a5
tlb.c 27 KB