• Khazhismel Kumykov's avatar
    dm mpath selector: more evenly distribute ties · f2042605
    Khazhismel Kumykov authored
    Move the last used path to the end of the list (least preferred) so that
    ties are more evenly distributed.
    
    For example, in case with three paths with one that is slower than
    others, the remaining two would be unevenly used if they tie. This is
    due to the rotation not being a truely fair distribution.
    
    Illustrated: paths a, b, c, 'c' has 1 outstanding IO, a and b are 'tied'
    Three possible rotations:
    (a, b, c) -> best path 'a'
    (b, c, a) -> best path 'b'
    (c, a, b) -> best path 'a'
    (a, b, c) -> best path 'a'
    (b, c, a) -> best path 'b'
    (c, a, b) -> best path 'a'
    ...
    
    So 'a' is used 2x more than 'b', although they should be used evenly.
    
    With this change, the most recently used path is always the least
    preferred, removing this bias resulting in even distribution.
    (a, b, c) -> best path 'a'
    (b, c, a) -> best path 'b'
    (c, a, b) -> best path 'a'
    (c, b, a) -> best path 'b'
    ...
    Signed-off-by: default avatarKhazhismel Kumykov <khazhy@google.com>
    Reviewed-by: default avatarMartin Wilck <mwilck@suse.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    f2042605
dm-queue-length.c 5.91 KB