• Taiping Lai's avatar
    gpio: sprd: Clear interrupt when setting the type as edge · 5fcface6
    Taiping Lai authored
    The raw interrupt status of GPIO maybe set before the interrupt is enabled,
    which would trigger the interrupt event once enabled it from user side.
    This is the case for edge interrupts only. Adding a clear operation when
    setting interrupt type can avoid that.
    
    There're a few considerations for the solution:
    1) This issue is for edge interrupt only; The interrupts requested by users
       are IRQ_TYPE_LEVEL_HIGH as default, so clearing interrupt when request
       is useless.
    2) The interrupt type can be set to edge when request and following up
       with clearing it though, but the problem is still there once users set
       the interrupt type to level trggier.
    3) We can add a clear operation after each time of setting interrupt
       enable bit, but it is redundant for level trigger interrupt.
    
    Therefore, the solution is this patch seems the best for now.
    
    Fixes: 9a3821c2 ("gpio: Add GPIO driver for Spreadtrum SC9860 platform")
    Signed-off-by: default avatarTaiping Lai <taiping.lai@unisoc.com>
    Signed-off-by: default avatarChunyan Zhang <chunyan.zhang@unisoc.com>
    Reviewed-by: default avatarBaolin Wang <baolin.wang7@gmail.com>
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    5fcface6
gpio-sprd.c 7.91 KB