• Bjørn Mork's avatar
    [PATCH] I2C: "probe" module param broken for it87 in Linux 2.6.6 · 4b36b0cf
    Bjørn Mork authored
    Jean Delvare <khali@linux-fr.org> writes:
    > So I'd suggest that you simply use the standard exit sequence in the
    > it87 driver (the second one in your current patch). A patch for the 2.4
    > driver would be appreciated as well.
    
    OK.  I've attached a new version of the patch against linux-2.6.6.
    I'll send a patch against current lm_sensors CVS removing the extra
    exit command in a separate mail.
    
    Greg KH <greg@kroah.com> writes:
    > On Wed, May 12, 2004 at 04:38:03PM +0200, Bj?rn Mork wrote:
    >> +	if (!it87_find(&addr)) {
    >> +		printk("it87.o: new ISA address: 0x%04x\n", addr);
    >
    > That printk is wrong (no KERN_ level, or dev_printk() style use).
    > Please fix it in your next revision of this patch.
    
    Errh, I just added it to document my sloppyness.  It was never meant
    to be in the patch I sent you.  Sorry.  Removed in the attached patch.
    The style of these drivers seem to be "just working, making no noise"
    so I assume informational printk's are unwanted.
    4b36b0cf
it87.c 28.4 KB