• David Hildenbrand's avatar
    mm/gup: use gup_can_follow_protnone() also in GUP-fast · 0cf45986
    David Hildenbrand authored
    There seems to be no reason why FOLL_FORCE during GUP-fast would have to
    fallback to the slow path when stumbling over a PROT_NONE mapped page.  We
    only have to trigger hinting faults in case FOLL_FORCE is not set, and any
    kind of fault handling naturally happens from the slow path -- where NUMA
    hinting accounting/handling would be performed.
    
    Note that the comment regarding THP migration is outdated: commit
    2b4847e7 ("mm: numa: serialise parallel get_user_page against THP
    migration") described that this was required for THP due to lack of PMD
    migration entries.  Nowadays, we do have proper PMD migration entries in
    place -- see set_pmd_migration_entry(), which does a proper
    pmdp_invalidate() when placing the migration entry.
    
    So let's just reuse gup_can_follow_protnone() here to make it consistent
    and drop the somewhat outdated comments.
    
    Link: https://lkml.kernel.org/r/20220825164659.89824-3-david@redhat.comSigned-off-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Jason Gunthorpe <jgg@nvidia.com>
    Cc: John Hubbard <jhubbard@nvidia.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: Peter Xu <peterx@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    0cf45986
gup.c 92.5 KB