• Tobin C. Harding's avatar
    staging: ks7010: abstract connection status · 0e24eb8a
    Tobin C. Harding authored
    Host interface connection status is handled using a 32 bit type. Top
    byte is used as for FORCE_DISCONNECT status, low bits are used for
    connect/disconnect status. Driver masks and checks integers to
    ascertain status. If functions are defined to do the masking and
    equality check then the details of how the status integer is used are
    abstracted away. This makes the code easier to read. Also future
    updates to the status handling will be easier because the code is in
    one place.
    
    Driver currently uses the CONNECT_STATUS and DISCONNECT_STATUS as
    values, as apposed to opaque values. Because of this driver code
    checks for equality with CONNECT_STATUS and DISCONNECT_STATUS as
    apposed to negating a single check (ie 'foo != CONNECT_STATUS). In
    order to maintain the current functionality we define two separate
    functions is_connect_status() and is_disconnect_status().
    
    Add functions to abstract the status integer check. Update all sites
    that do the check manually to use the newly defined functions.
    Signed-off-by: default avatarTobin C. Harding <me@tobin.cc>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    0e24eb8a
ks7010_sdio.c 26.1 KB