• Magnus Lynch's avatar
    USB: serial: qcserial: expose methods for modem control · 08f741a9
    Magnus Lynch authored
    The qcserial driver fails to expose the .tiocmget and .tiocmset methods
    available from usb_wwan. These methods are required by ioctl commands
    dealing with the modem control signals DTR, RTS, etc.
    
    With these methods not set ioctl calls intended to control the DTR state
    will fail. For example, pppd drops and raises DTR in preparation to
    dialing the modem, which handles the case of the modem already being
    connected by making it hang up and return to command mode. DTR control
    being unavailable will lead to a protracted failure to connect as the
    modem will be stuck in a state not responsive to command.
    
    I have tested that with this patch the described case is handled
    successfully. There is an analogous method for .ioctl available from
    usb_wwan (as used in option.c) but I conservatively omitted that for
    lack of familiarity.
    Signed-off-by: default avatarMagnus Lynch <maglyx@gmail.com>
    Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
    08f741a9
qcserial.c 16.5 KB