• Hans de Goede's avatar
    ASoC: Intel: cht_bsw_rt5645: Cleanup codec_name handling · 930375d3
    Hans de Goede authored
    4 fixes / cleanups to the rt5645 mc driver's codec_name handling:
    
    1. In the for loop looking for the dai_index for the codec, replace
    card->dai_link[i] with cht_dailink[i]. The for loop already uses
    ARRAY_SIZE(cht_dailink) as bound and card->dai_link is just a pointer to
    cht_dailink using card->dai_link only obfuscates that cht_dailink is being
    modified directly rather then say a copy of cht_dailink. Using
    cht_dailink[i] also makes the code consistent with other machine drivers.
    
    2. Don't set cht_dailink[dai_index].codecs->name in the for loop,
    this immediately gets overridden using acpi_dev_name(adev) directly
    below the loop.
    
    3. Add a missing break to the loop.
    
    4. Remove the now no longer used (only set, never read) codec_name field
    from struct cht_mc_private.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20240210134400.24913-3-hdegoede@redhat.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    930375d3
cht_bsw_rt5645.c 20.8 KB