• Ian Rogers's avatar
    perf parse-events: Avoid use uninitialized warning · 0f97a3a0
    Ian Rogers authored
    With GCC LTO a potential use uninitialized is spotted:
    ```
    In function ‘parse_events_config_bpf’,
        inlined from ‘parse_events_load_bpf’ at util/parse-events.c:874:8:
    util/parse-events.c:792:37: error: ‘error_pos’ may be used uninitialized [-Werror=maybe-uninitialized]
      792 |                                 idx = term->err_term + error_pos;
          |                                     ^
    util/parse-events.c: In function ‘parse_events_load_bpf’:
    util/parse-events.c:765:13: note: ‘error_pos’ was declared here
      765 |         int error_pos;
          |             ^
    ```
    So initialize at declaration.
    Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Carsten Haitzler <carsten.haitzler@arm.com>
    Cc: Fangrui Song <maskray@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: James Clark <james.clark@arm.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Kan Liang <kan.liang@linux.intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Tom Rix <trix@redhat.com>
    Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
    Cc: Yang Jihong <yangjihong1@huawei.com>
    Cc: bpf@vger.kernel.org
    Cc: llvm@lists.linux.dev
    Link: https://lore.kernel.org/r/20230724201247.748146-3-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    0f97a3a0
parse-events.c 70.9 KB