• Al Viro's avatar
    ITER_PIPE: cache the type of last buffer · 10f525a8
    Al Viro authored
    We often need to find whether the last buffer is anon or not, and
    currently it's rather clumsy:
    	check if ->iov_offset is non-zero (i.e. that pipe is not empty)
    	if so, get the corresponding pipe_buffer and check its ->ops
    	if it's &default_pipe_buf_ops, we have an anon buffer.
    
    Let's replace the use of ->iov_offset (which is nowhere near similar to
    its role for other flavours) with signed field (->last_offset), with
    the following rules:
    	empty, no buffers occupied:		0
    	anon, with bytes up to N-1 filled:	N
    	zero-copy, with bytes up to N-1 filled:	-N
    
    That way abs(i->last_offset) is equal to what used to be in i->iov_offset
    and empty vs. anon vs. zero-copy can be distinguished by the sign of
    i->last_offset.
    
    	Checks for "should we extend the last buffer or should we start
    a new one?" become easier to follow that way.
    
    	Note that most of the operations can only be done in a sane
    state - i.e. when the pipe has nothing past the current position of
    iterator.  About the only thing that could be done outside of that
    state is iov_iter_advance(), which transitions to the sane state by
    truncating the pipe.  There are only two cases where we leave the
    sane state:
    	1) iov_iter_get_pages()/iov_iter_get_pages_alloc().  Will be
    dealt with later, when we make get_pages advancing - the callers are
    actually happier that way.
    	2) iov_iter copied, then something is put into the copy.  Since
    they share the underlying pipe, the original gets behind.  When we
    decide that we are done with the copy (original is not usable until then)
    we advance the original.  direct_io used to be done that way; nowadays
    it operates on the original and we do iov_iter_revert() to discard
    the excessive data.  At the moment there's nothing in the kernel that
    could do that to ITER_PIPE iterators, so this reason for insane state
    is theoretical right now.
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    10f525a8
iov_iter.c 48.2 KB