• Thomas Gleixner's avatar
    acpi: Fix broken error check in map_processor() · c183a603
    Thomas Gleixner authored
    map_processor() checks the cpuid value returned by acpi_map_cpuid() for -1
    but acpi_map_cpuid() returns -EINVAL in case of error.
    
    As a consequence the error is ignored and the following access into percpu
    data with that negative cpuid results in a boot crash.
    
    This happens always when NR_CPUS/nr_cpu_ids is smaller than the number of
    processors listed in the ACPI tables.
    
    Use a proper error check for id < 0 so the function returns instead of
    trying to map CPU#(-EINVAL).
    Reported-by: default avatarIngo Molnar <mingo@kernel.org>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>
    Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Tang Chen <tangchen@cn.fujitsu.com>
    Cc: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
    Cc: akpm@linux-foundation.org
    Cc: chen.tang@easystack.cn
    Cc: cl@linux.com
    Cc: gongzhaogang@inspur.com
    Cc: isimatu.yasuaki@jp.fujitsu.com
    Cc: izumi.taku@jp.fujitsu.com
    Cc: kamezawa.hiroyu@jp.fujitsu.com
    Cc: len.brown@intel.com
    Cc: lenb@kernel.org
    Cc: linux-acpi@vger.kernel.org
    Cc: linux-mm@kvack.org
    Cc: mika.j.penttila@gmail.com
    Cc: rafael@kernel.org
    Cc: rjw@rjwysocki.net
    Cc: tj@kernel.org
    Cc: yasu.isimatu@gmail.com
    Fixes: dc6db24d ("x86/acpi: Set persistent cpuid <-> nodeid mapping when booting")
    Link: http://lkml.kernel.org/r/alpine.DEB.2.20.1609231705570.5640@nanosSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    c183a603
processor_core.c 11.4 KB