• Peter Zijlstra's avatar
    perf/x86: Fix overlap counter scheduling bug · 1134c2b5
    Peter Zijlstra authored
    Jiri reported the overlap scheduling exceeding its max stack.
    
    Looking at the constraint that triggered this, it turns out the
    overlap marker isn't needed.
    
    The comment with EVENT_CONSTRAINT_OVERLAP states: "This is the case if
    the counter mask of such an event is not a subset of any other counter
    mask of a constraint with an equal or higher weight".
    
    Esp. that latter part is of interest here I think, our overlapping mask
    is 0x0e, that has 3 bits set and is the highest weight mask in on the
    PMU, therefore it will be placed last. Can we still create a scenario
    where we would need to rewind that?
    
    The scenario for AMD Fam15h is we're having masks like:
    
    	0x3F -- 111111
    	0x38 -- 111000
    	0x07 -- 000111
    
    	0x09 -- 001001
    
    And we mark 0x09 as overlapping, because it is not a direct subset of
    0x38 or 0x07 and has less weight than either of those. This means we'll
    first try and place the 0x09 event, then try and place 0x38/0x07 events.
    Now imagine we have:
    
    	3 * 0x07 + 0x09
    
    and the initial pick for the 0x09 event is counter 0, then we'll fail to
    place all 0x07 events. So we'll pop back, try counter 4 for the 0x09
    event, and then re-try all 0x07 events, which will now work.
    
    The masks on the PMU in question are:
    
      0x01 - 0001
      0x03 - 0011
      0x0e - 1110
      0x0c - 1100
    
    But since all the masks that have overlap (0xe -> {0xc,0x3}) and (0x3 ->
    0x1) are of heavier weight, it should all work out.
    Reported-by: default avatarJiri Olsa <jolsa@kernel.org>
    Tested-by: default avatarJiri Olsa <jolsa@kernel.org>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Liang Kan <kan.liang@intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Robert Richter <rric@kernel.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vince Weaver <vince@deater.net>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Link: http://lkml.kernel.org/r/20161109155153.GQ3142@twins.programming.kicks-ass.netSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    1134c2b5
uncore_snbep.c 115 KB