• Masami Hiramatsu's avatar
    perf tools: Fix machine__create_kernel_maps to put kernel dso refcount · 1154c957
    Masami Hiramatsu authored
    Fix machine__create_kernel_maps() to put kernel dso because the dso has
    been gotten via __machine__create_kernel_maps().
    
    Refcnt debugger shows:
      ==== [0] ====
      Unreclaimed dso: 0x3036ab0
      Refcount +1 => 1 at
        ./perf(dso__new+0x1ff) [0x4a62df]
        ./perf(__dsos__addnew+0x29) [0x4a6e19]
        ./perf(dsos__findnew+0xd1) [0x4a7181]
        ./perf(machine__findnew_kernel+0x27) [0x4a5e17]
        ./perf() [0x4b8cf2]
        ./perf(machine__create_kernel_maps+0x28) [0x4bb428]
        ./perf(machine__new_host+0xfa) [0x4bb74a]
        ./perf(init_probe_symbol_maps+0x93) [0x506613]
        ./perf() [0x455ffa]
        ./perf(cmd_probe+0x6c) [0x4566bc]
        ./perf() [0x47abc5]
        ./perf(main+0x610) [0x421f90]
        /lib64/libc.so.6(__libc_start_main+0xf5) [0x7ffa6809eaf5]
        ./perf() [0x4220a9]
      [snip]
      Refcount +1 => 2 at
        ./perf(dsos__findnew+0x7e) [0x4a712e]
        ./perf(machine__findnew_kernel+0x27) [0x4a5e17]
        ./perf() [0x4b8cf2]
        ./perf(machine__create_kernel_maps+0x28) [0x4bb428]
        ./perf(machine__new_host+0xfa) [0x4bb74a]
        ./perf(init_probe_symbol_maps+0x93) [0x506613]
        ./perf() [0x455ffa]
        ./perf(cmd_probe+0x6c) [0x4566bc]
        ./perf() [0x47abc5]
        ./perf(main+0x610) [0x421f90]
        /lib64/libc.so.6(__libc_start_main+0xf5) [0x7ffa6809eaf5]
        ./perf() [0x4220a9]
      [snip]
      Refcount -1 => 1 at
        ./perf(dso__put+0x2f) [0x4a664f]
        ./perf(machine__delete+0xfe) [0x4b93ee]
        ./perf(exit_probe_symbol_maps+0x28) [0x5066b8]
        ./perf() [0x45628a]
        ./perf(cmd_probe+0x6c) [0x4566bc]
        ./perf() [0x47abc5]
        ./perf(main+0x610) [0x421f90]
        /lib64/libc.so.6(__libc_start_main+0xf5) [0x7ffa6809eaf5]
        ./perf() [0x4220a9]
    
    Actually, dsos__findnew gets the dso before returning it, so the dso
    user (in this case machine__create_kernel_maps) has to put the dso after
    used.
    Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20151118064033.30709.98954.stgit@localhost.localdomainSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    1154c957
machine.c 48.8 KB