• Matwey V. Kornilov's avatar
    media: usb: pwc: Don't use coherent DMA buffers for ISO transfer · 1161db67
    Matwey V. Kornilov authored
    DMA cocherency slows the transfer down on systems without hardware
    coherent DMA.
    Instead we use noncocherent DMA memory and explicit sync at data receive
    handler.
    
    Based on previous commit the following performance benchmarks have been
    carried out. Average memcpy() data transfer rate (rate) and handler
    completion time (time) have been measured when running video stream at
    640x480 resolution at 10fps.
    
    x86_64 based system (Intel Core i5-3470). This platform has hardware
    coherent DMA support and proposed change doesn't make big difference here.
    
     * kmalloc:            rate = (2.0 +- 0.4) GBps
                           time = (5.0 +- 3.0) usec
     * usb_alloc_coherent: rate = (3.4 +- 1.2) GBps
                           time = (3.5 +- 3.0) usec
    
    We see that the measurements agree within error ranges in this case.
    So theoretically predicted performance downgrade cannot be reliably
    measured here.
    
    armv7l based system (TI AM335x BeagleBone Black @ 300MHz). This platform
    has no hardware coherent DMA support. DMA coherence is implemented via
    disabled page caching that slows down memcpy() due to memory controller
    behaviour.
    
     * kmalloc:            rate =  ( 94 +- 4) MBps
                           time =  (101 +- 4) usec
     * usb_alloc_coherent: rate = (28.1 +- 0.1) MBps
                           time =  (341 +- 2) usec
    
    Note, that quantative difference leads (this commit leads to 3.3 times
    acceleration) to qualitative behavior change in this case. As it was
    stated before, the video stream cannot be successfully received at AM335x
    platforms with MUSB based USB host controller due to performance issues
    [1].
    
    [1] https://www.spinics.net/lists/linux-usb/msg165735.htmlSigned-off-by: default avatarMatwey V. Kornilov <matwey@sai.msu.ru>
    Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
    1161db67
pwc-if.c 34.5 KB