• Anssi Hannula's avatar
    ALSA: hda - hdmi: Fix unused slots being enabled in manual and non-PCM mappings · 11f7c52d
    Anssi Hannula authored
    hdmi_manual_setup_channel_mapping() and hdmi_std_setup_channel_mapping
    try to assign ALSA channels to HDMI channel slots and disable (i.e.
    silence) other slots.
    
    However, they try to disable a slot by using AC_VERB_SET_CHAN_SLOT with
    parameter ((alsa_ch << 8) | 0xf), while the correct parameter is
    ((0xf << 8) | hdmi_slot), i.e. the slot should be unassigned, not the
    ALSA channel.
    
    Fix that by actually disabling the unused slots.
    
    Note that this bug did not cause any (reported) issues because slots
    incorrectly having audio are normally ignored by a receiver if the CEA
    channel allocation used does not map that slot to any speaker.
    Additionally, the converter channel count configuration limits the
    number of actually active channels in any case.
    Signed-off-by: default avatarAnssi Hannula <anssi.hannula@iki.fi>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    11f7c52d
patch_hdmi.c 77.1 KB