• Matt Roper's avatar
    drm/i915/icl: Drop a couple unnecessary workarounds · 131b1252
    Matt Roper authored
    While doing a quick sanity check of the ICL workarounds in the driver I
    noticed a few things that should be updated:
    
     * There's no mention in the bspec that WaPipelineFlushCoherentLines
       is needed on gen11 (both the current WA database and the old,
       deprecated page 20196 were checked); it appears this might have just
       been copied from the gen9 list?  Even if this were needed, it doesn't
       seem like this was the correct implementation anyway since the gen9
       workaround is supposed to be implemented in the indirect context bb
       (as we do in gen8_emit_flush_coherentl3_wa() on gen8/gen9).
    
     * WaForwardProgressSoftReset does not appear in the current workaround
       database.  The old deprecated workaround list has a note indicating
       the workaround was dropped in 2017, so we should be safe to drop it
       from the code too.
    
    While we're at it, add the formal workaround ID number to
    WaDisableBankHangMode (our hardware team made a transition from
    text-based workaround names to ID numbers partway through the
    development of ICL, which is why some workarounds only have names, some
    only have numbers, and some have both).
    
    Bspec: 33450
    Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
    Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210717051426.4120328-3-matthew.d.roper@intel.com
    131b1252
intel_workarounds.c 57.3 KB