• James Morse's avatar
    x86/resctrl: Make ctrlval arrays the same size · 141739aa
    James Morse authored
    The CODE and DATA resources report a num_closid that is half the actual
    size supported by the hardware. This behaviour is visible to user-space
    when CDP is enabled.
    
    The CODE and DATA resources have their own ctrlval arrays which are
    half the size of the underlying hardware because num_closid was already
    adjusted. One holds the odd configurations values, the other even.
    
    Before the CDP resources can be merged, the 'half the closids' behaviour
    needs to be implemented by schemata_list_create(), but this causes the
    ctrl_val[] array to be full sized.
    
    Remove the logic from the architecture specific rdt_get_cdp_config()
    setup, and add it to schemata_list_create(). Functions that walk all the
    configurations, such as domain_setup_ctrlval() and reset_all_ctrls(),
    take num_closid directly from struct rdt_hw_resource also have
    to halve num_closid as only the lower half of each array is in
    use. domain_setup_ctrlval() and reset_all_ctrls() both copy struct
    rdt_hw_resource's num_closid to a struct msr_param. Correct the value
    here.
    
    This is temporary as a subsequent patch will merge all three ctrl_val[]
    arrays such that when CDP is in use, the CODA/DATA layout in the array
    matches the hardware. reset_all_ctrls()'s loop over the whole of
    ctrl_val[] is not touched as this is harmless, and will be required as
    it is once the resources are merged.
    Signed-off-by: default avatarJames Morse <james.morse@arm.com>
    Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
    Reviewed-by: default avatarJamie Iles <jamie@nuviainc.com>
    Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
    Tested-by: default avatarBabu Moger <babu.moger@amd.com>
    Link: https://lkml.kernel.org/r/20210728170637.25610-19-james.morse@arm.com
    141739aa
core.c 27.5 KB