• Jiri Olsa's avatar
    perf build: Move feature cleanup under tools/build · 762323eb
    Jiri Olsa authored
    Arnaldo reported issue for following build command:
    
      $ rm -rf /tmp/krava; mkdir /tmp/krava; make O=/tmp/krava clean
        CLEAN    config
      /bin/sh: line 0: cd: /tmp/krava/feature/: No such file or directory
      ../../scripts/Makefile.include:17: *** output directory "/tmp/krava/feature/" does not exist.  Stop.
      make[1]: *** [Makefile.perf:1010: config-clean] Error 2
      make: *** [Makefile:90: clean] Error 2
    
    The problem is that now that we include scripts/Makefile.include
    in feature's Makefile (which is fine and needed), we need to ensure
    the OUTPUT directory exists, before executing (out of tree) clean
    command.
    
    Removing the feature's cleanup from perf Makefile and fixing
    feature's cleanup under build Makefile, so it now checks that
    there's existing OUTPUT directory before calling the clean.
    
    Fixes: 211a741c ("tools: Factor Clang, LLC and LLVM utils definitions")
    Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM/Clang v13-git
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Michael Petlan <mpetlan@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210224150831.409639-1-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    762323eb
Makefile 1.26 KB