• Petr Kulhavy's avatar
    dmaengine: edma: fix memory leak when terminating running transfers · 14a39537
    Petr Kulhavy authored
    commit 5ca9e7ce upstream.
    
    If edma_terminate_all() was called while a transfer was running (i.e. after
    edma_execute() but before edma_callback()) the echan->edesc was not freed.
    
    This was due to the fact that a running transfer is on none of the
    vchan lists: desc_submitted, desc_issued, desc_completed (edma_execute()
    removes it from the desc_issued list), so the vchan_dma_desc_free_list()
    called at the end of edma_terminate_all() didn't find it and didn't free it.
    
    This bug was found on an AM1808 based hardware (very similar to da850evm,
    however using the second MMC/SD controller), where intense operations on the SD
    card wasted the device 128MB RAM within a couple of days.
    
    Peter Ujfalusi:
    The issue is even more severe since it affects cyclic (audio) transfers as
    well. In this case starting/stopping audio will results memory leak.
    Signed-off-by: default avatarPetr Kulhavy <petr@barix.com>
    Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
    CC: <linux-omap@vger.kernel.org>
    Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
    [ luis: backported to 3.16: adjusted context ]
    Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
    14a39537
edma.c 29.8 KB