• Xie He's avatar
    net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner · 14b20704
    Xie He authored
    The eth_type_trans function is called when we receive frames carrying
    Ethernet frames. This function expects a non-NULL pointer as an argument,
    and assigns it directly to skb->dev.
    
    However, the code handling other types of frames first assigns the pointer
    to "dev", and then at the end checks whether the value is NULL, and if it
    is not NULL, assigns it to skb->dev.
    
    The two flows are different. Mixing them in this function makes the code
    messy. It's better that we convert the second flow to align with how
    eth_type_trans does things.
    
    So this patch changes the code to: first make sure the pointer is not
    NULL, then assign it directly to skb->dev. "dev" is no longer needed until
    the end where we use it to update stats.
    
    Cc: Krzysztof Halasa <khc@pm.waw.pl>
    Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
    Signed-off-by: default avatarXie He <xie.he.0141@gmail.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    14b20704
hdlc_fr.c 29.3 KB