• Sean Christopherson's avatar
    KVM: Stop looking for coalesced MMIO zones if the bus is destroyed · 5d3c4c79
    Sean Christopherson authored
    Abort the walk of coalesced MMIO zones if kvm_io_bus_unregister_dev()
    fails to allocate memory for the new instance of the bus.  If it can't
    instantiate a new bus, unregister_dev() destroys all devices _except_ the
    target device.   But, it doesn't tell the caller that it obliterated the
    bus and invoked the destructor for all devices that were on the bus.  In
    the coalesced MMIO case, this can result in a deleted list entry
    dereference due to attempting to continue iterating on coalesced_zones
    after future entries (in the walk) have been deleted.
    
    Opportunistically add curly braces to the for-loop, which encompasses
    many lines but sneaks by without braces due to the guts being a single
    if statement.
    
    Fixes: f6588660 ("KVM: fix memory leak in kvm_io_bus_unregister_dev()")
    Cc: stable@vger.kernel.org
    Reported-by: default avatarHao Sun <sunhao.th@gmail.com>
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20210412222050.876100-3-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    5d3c4c79
coalesced_mmio.c 4.86 KB