• Stefan Richter's avatar
    firedtv: massive refactoring · 15490795
    Stefan Richter authored
    Combination of the following changes:
    
    Mon, 23 Feb 2009 14:21:10 +0100 (CET)
    firedtv: reinstate debug logging option
    
        Henrik Kurelid tells me that FCP debug logging (which I removed during
        cleanups) is still useful when working on driver issues together with
        end users.  So bring it back in an updated form with only 60% of the
        original code footprint.
    
        Logging can be enabled with
        # echo -1 > /sys/module/firedtv/parameters/debug
    
        1 instead of -1 enables only FCP header logging,
        2 instead of -1 enables only hexdumps of the entire FCP frames.
        0 switches logging off again.
    
    Fri, 20 Feb 2009 20:54:27 +0100 (CET)
    firedtv: build fix for INPUT=m and DVB_FIREDTV=y
    
    Thu, 19 Feb 2009 20:40:39 +0100
    firedtv: use msecs_to_jiffies
    
        Pointed out by Mauro Carvalho Chehab.
    
    Sun Feb 15 20:50:46 CET 2009
    firedtv: some more housekeeping
    
        Fix an old checkpatch warning and a new compiler warning.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: rename a file once more
    
        At the moment, about a third of avc.c is specific to FireDTVs rather
        than generic AV/C code.  Rename it to firedtv-avc.c.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: dvb demux: more compact channels backing store
    
        Replace struct firedtv_channel { bool active; int pid; } channel[16];
        by unsigned long channel_active; u16 channel_pid[16];.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: dvb demux: some simplifications
    
        c->active was unnecessarily cleared twice.
    
        Also, by marking the channel inactive before the for loop,
        the loop becomes identical with fdtv_channel_collect().
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: dvb demux: remove a bogus loop
    
        This loop is unnecessary because
          - only active channel[].pid's will be sent to the device,
          - when a channel is activated, its pid is set to dvbdmxfeed->pid.
    
        Perhaps the original code was there because it was initially not fully
        covered by the fdtv->demux_mutex.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: dvb demux: fix mutex protection
    
        fdtv_start_feed() accessed the channel list unsafely.
        Fully serialize it with itself and fdtv_stop_feed().
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: dvb demux: fix missing braces
    
        Original code was:
                ...
                case DMX_TS_PES_OTHER:
                        //Dirty fix to keep firesat->channel pid-list up to date
                        for(k=0;k<16;k++){
                                if(firesat->channel[k].active == 0)
                                        firesat->channel[k].pid =
                                                dvbdmxfeed->pid;
                                        break;
                        }
                        channel = firesat_channel_allocate(firesat);
                        break;
                default:
                ...
    
        Looks bogus in several respects. For now let's just add braces to the if
        because that seems to be what the author meant.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: allow build without input subsystem
    
        !CONFIG_INPUT is very unlikely on systems on which firedtv is of
        interest.  But we can easily support it.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: replace EXTRA_CFLAGS by ccflags
    
        The former are deprecated.
        The latter can depend on Kconfig variables.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: concentrate ieee1394 dependencies
    
        Move the entire interface with drivers/ieee1394 to firedtv-1394.c.
        Move 1394-independent module initialization code to firedtv-dvb.c.
    
        This prepares interfacing with drivers/firewire.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: amend Kconfig menu prompt
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: remove kernel version compatibility macro
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: combine header files
    
        avc.h and firedtv-*.h are small and currently not shared with other
        drivers, hence concatenate them all into firedtv.h.
    
    Sun Feb 15 15:33:17 CET 2009
    firedtv: misc style touch-ups
    
        Standardize on lower-case hexadecimal constants.  Adjust whitespace.
        Omit unnecessary pointer type casts and an unnecessary list head
        initialization.  Use dev_printk.
    
    Wed Feb 11 21:21:04 CET 2009
    firedtv: avc, ci: remove unused constants
    
    Wed Feb 11 21:21:04 CET 2009
    firedtv: avc: remove bitfields from read descriptor response operands
    
        Don't use bitfields in struct types of on-the-wire data.
    
    Wed Feb 11 21:21:04 CET 2009
    firedtv: avc: remove bitfields from DSD command operands
    
        Don't use bitfields in struct types of on-the-wire data.
    
    Wed Feb 11 21:21:04 CET 2009
    firedtv: avc: header file cleanup
    
        Remove unused constants and declarations.
        Move privately used constants into .c files.
    
    Wed Feb 11 21:21:04 CET 2009
    firedtv: avc: remove bitfields from FCP frame types
    
        Don't use bitfields in struct types of on-the-wire data.
    
        Also move many privately used constants from avc.h to avc.c
        and remove some unused constants.
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: avc: fix offset in avc_tuner_get_ts
    
        The parentheses were wrong.  It didn't matter though because this code
        only writes a 0 into an area which is already initialized to 0.
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: avc: reduce stack usage, remove two typedefs
    
        It is safe to share a memory buffer for command frame and response frame
        because the response data come in after the command frame was last used.
    
        Even less stack would be required if only the actual required frame size
        instead of the entire FCP register size was allocated.
    
        Also, rename the defined types AVCCmdFrm and AVCRspFrm to
        struct avc_command_frame and struct avc_response_frame.
        TODO:  Remove the bitfields in these types.
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: cmp: move code to avc
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: iso: move code to firedtv-1394
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: iso: remove unnecessary struct type definitions
    
    Sun, 18 Jan 2009 16:30:00 +0100 (CET)
    firedtv: iso: style changes and fixlets
    
        Add cleanup after failure in setup_iso_channel.
        Replace printk() by dv_err().
        Decrease indentation level in rawiso_activity_cb().
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    15490795
firedtv-avc.c 36.2 KB