• Paul E. McKenney's avatar
    srcu: Check for tardy grace-period activity in cleanup_srcu_struct() · 15c68f7f
    Paul E. McKenney authored
    Users of SRCU are obliged to complete all grace-period activity before
    invoking cleanup_srcu_struct().  This means that all calls to either
    synchronize_srcu() or synchronize_srcu_expedited() must have returned,
    and all calls to call_srcu() must have returned, and the last call to
    call_srcu() must have been followed by a call to srcu_barrier().
    Furthermore, the caller must have done something to prevent any
    further calls to synchronize_srcu(), synchronize_srcu_expedited(),
    and call_srcu().
    
    Therefore, if there has ever been an invocation of call_srcu() on
    the srcu_struct in question, the sequence of events must be as
    follows:
    
    1.  Prevent any further calls to call_srcu().
    2.  Wait for any pre-existing call_srcu() invocations to return.
    3.  Invoke srcu_barrier().
    4.  It is now safe to invoke cleanup_srcu_struct().
    
    On the other hand, if there has ever been a call to synchronize_srcu()
    or synchronize_srcu_expedited(), the sequence of events must be as
    follows:
    
    1.  Prevent any further calls to synchronize_srcu() or
        synchronize_srcu_expedited().
    2.  Wait for any pre-existing synchronize_srcu() or
        synchronize_srcu_expedited() invocations to return.
    3.  It is now safe to invoke cleanup_srcu_struct().
    
    If there have been calls to all both types of functions (call_srcu()
    and either of synchronize_srcu() and synchronize_srcu_expedited()), then
    the caller must do the first three steps of the call_srcu() procedure
    above and the first two steps of the synchronize_s*() procedure above,
    and only then invoke cleanup_srcu_struct().
    
    Note that cleanup_srcu_struct() does some probabilistic checks
    for the caller failing to follow these procedures, in which case
    cleanup_srcu_struct() does WARN_ON() and avoids freeing the per-CPU
    structures associated with the specified srcu_struct structure.
    Reported-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
    Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
    15c68f7f
srcu.c 21.4 KB