• Maxime Ripard's avatar
    clk: imx: scu: Switch to determine_rate · 15d3f365
    Maxime Ripard authored
    The iMX SCU clocks implements a mux with a set_parent hook, but doesn't
    provide a determine_rate implementation.
    
    This is a bit odd, since set_parent() is there to, as its name implies,
    change the parent of a clock. However, the most likely candidate to
    trigger that parent change is a call to clk_set_rate(), with
    determine_rate() figuring out which parent is the best suited for a
    given rate.
    
    The other trigger would be a call to clk_set_parent(), but it's far less
    used, and it doesn't look like there's any obvious user for that clock.
    
    So, the set_parent hook is effectively unused, possibly because of an
    oversight. However, it could also be an explicit decision by the
    original author to avoid any reparenting but through an explicit call to
    clk_set_parent().
    
    The driver does implement round_rate() though, which means that we can
    change the rate of the clock, but we will never get to change the
    parent.
    
    However, It's hard to tell whether it's been done on purpose or not.
    
    Since we'll start mandating a determine_rate() implementation, let's
    convert the round_rate() implementation to a determine_rate(), which
    will also make the current behavior explicit. The round_rate()
    implementation being shared with other clocks, it's not removed.
    
    And if it was an oversight, the clock behaviour can be adjusted later
    on.
    
    Cc: Abel Vesa <abelvesa@kernel.org>
    Cc: Fabio Estevam <festevam@gmail.com>
    Cc: Peng Fan <peng.fan@nxp.com>
    Cc: Sascha Hauer <s.hauer@pengutronix.de>
    Cc: Shawn Guo <shawnguo@kernel.org>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: NXP Linux Team <linux-imx@nxp.com>
    Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
    Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
    Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v4-58-971d5077e7d2@cerno.techSigned-off-by: default avatarStephen Boyd <sboyd@kernel.org>
    15d3f365
clk-scu.c 21.1 KB