• Andrew Morton's avatar
    [PATCH] rmap 22 flush_dcache_mmap_lock · 16ceff2d
    Andrew Morton authored
    From: Hugh Dickins <hugh@veritas.com>
    
    arm and parisc __flush_dcache_page have been scanning the i_mmap(_shared) list
    without locking or disabling preemption.  That may be even more unsafe now
    it's a prio tree instead of a list.
    
    It looks like we cannot use i_shared_lock for this protection: most uses of
    flush_dcache_page are okay, and only one would need lock ordering fixed
    (get_user_pages holds page_table_lock across flush_dcache_page); but there's a
    few (e.g.  in net and ntfs) which look as if they're using it in I/O
    completion - and it would be restrictive to disallow it there.
    
    So, on arm and parisc only, define flush_dcache_mmap_lock(mapping) as
    spin_lock_irq(&(mapping)->tree_lock); on i386 (and other arches left to the
    next patch) define it away to nothing; and use where needed.
    
    While updating locking hierarchy in filemap.c, remove two layers of the fossil
    record from add_to_page_cache comment: no longer used for swap.
    
    I believe all the #includes will work out, but have only built i386.  I can
    see several things about this patch which might cause revulsion: the name
    flush_dcache_mmap_lock?  the reuse of the page radix_tree's tree_lock for this
    different purpose?  spin_lock_irqsave instead?  can't we somehow get
    i_shared_lock to handle the problem?
    16ceff2d
cacheflush.h 4.89 KB