• Yi Yang's avatar
    xtensa/simdisk: fix proc_read_simdisk() · b011946d
    Yi Yang authored
    The commit a69755b1 ("xtensa simdisk: switch to proc_create_data()")
    split read operation into two parts, first retrieving the path when it's
    non-null and second retrieving the trailing '\n'. However when the path
    is non-null the first simple_read_from_buffer updates ppos, and the
    second simple_read_from_buffer returns 0 if ppos is greater than 1 (i.e.
    almost always). As a result reading from that proc file is almost always
    empty.
    
    Fix it by making a temporary copy of the path with the trailing '\n' and
    using simple_read_from_buffer on that copy.
    
    Cc: stable@vger.kernel.org
    Fixes: a69755b1 ("xtensa simdisk: switch to proc_create_data()")
    Signed-off-by: default avatarYi Yang <yiyang13@huawei.com>
    Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
    b011946d
simdisk.c 7.99 KB