• Yang Jihong's avatar
    perf debug: Set debug_peo_args and redirect_to_stderr variable to correct... · 188ac720
    Yang Jihong authored
    perf debug: Set debug_peo_args and redirect_to_stderr variable to correct values in perf_quiet_option()
    
    When perf uses quiet mode, perf_quiet_option() sets the 'debug_peo_args'
    variable to -1, and display_attr() incorrectly determines the value of
    'debug_peo_args'.  As a result, unexpected information is displayed.
    
    Before:
    
      # perf record --quiet -- ls > /dev/null
      ------------------------------------------------------------
      perf_event_attr:
        size                             128
        { sample_period, sample_freq }   4000
        sample_type                      IP|TID|TIME|PERIOD
        read_format                      ID|LOST
        disabled                         1
        inherit                          1
        mmap                             1
        comm                             1
        freq                             1
        enable_on_exec                   1
        task                             1
        precise_ip                       3
        sample_id_all                    1
        exclude_guest                    1
        mmap2                            1
        comm_exec                        1
        ksymbol                          1
        bpf_event                        1
      ------------------------------------------------------------
      ...
    
    After:
      # perf record --quiet -- ls > /dev/null
      #
    
    redirect_to_stderr is a similar problem.
    
    Fixes: f78eaef0 ("perf tools: Allow to force redirect pr_debug to stderr.")
    Fixes: ccd26741 ("perf tool: Provide an option to print perf_event_open args and return value")
    Suggested-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
    Signed-off-by: default avatarYang Jihong <yangjihong1@huawei.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Carsten Haitzler <carsten.haitzler@arm.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: martin.lau@kernel.org
    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ravi Bangoria <ravi.bangoria@amd.com>
    Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
    Link: https://lore.kernel.org/r/20221220035702.188413-2-yangjihong1@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    188ac720
debug.c 5.95 KB