• Krzysztof Kozlowski's avatar
    compal-laptop: Check return value of power_supply_register · 1915a718
    Krzysztof Kozlowski authored
    The return value of power_supply_register() call was not checked and
    even on error probe() function returned 0. If registering failed then
    during unbind the driver tried to unregister power supply which was not
    actually registered.
    
    This could lead to memory corruption because power_supply_unregister()
    unconditionally cleans up given power supply.
    
    Fix this by checking return status of power_supply_register() call. In
    case of failure, clean up sysfs entries and fail the probe.
    Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
    Fixes: 9be0fcb5 ("compal-laptop: add JHL90, battery & hwmon interface")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
    1915a718
compal-laptop.c 29 KB