• Matt Roper's avatar
    drm/xe: Infer service copy functionality from engine list · 1951dad5
    Matt Roper authored
    On platforms with multiple BCS engines (i.e., PVC and Xe2), not all BCS
    engines are created equal.  The BCS0 engine is what the specs refer to
    as a "resource copy engine," which supports the platform's full set of
    copy/fill instructions.  In contast, the non-BCS0 "service copy" engines
    are more streamlined and only support a subset of the GPU instructions
    supported by the resource copy engine.  Platforms with both types of
    copy engines always support the MEM_COPY and MEM_SET instructions which
    can be used for simple copy and fill operations on either type of BCS
    engine.  Since the simple MEM_SET instruction meets the needs of Xe's
    migrate code (and since the more elaborate XY_FAST_COLOR_BLT instruction
    isn't available to use on service copy engines), we always prefer to use
    MEM_SET for clearing buffers on our newer platforms.
    
    We've been using a 'has_link_copy_engine' feature flag to keep track of
    which platforms should use MEM_SET for fills.  However a feature flag
    like this is unnecessary since we can already derive the presence of
    service copy engines (and in turn the MEM_SET instruction) just by
    looking at the platform's pre-fusing engine list.  Utilizing the engine
    list for this also avoids mistakes like we've made on Xe2 where we
    forget to set the feature flag in the IP definition.
    
    For clarity, "service copy" is a general term that covers any blitter
    engines that support a limited subset of the overall blitter instruction
    set (in practice this is any non-BCS0 blitter engine).  The "link copy
    engines" introduced on PVC and the "paging copy engine" present in Xe2
    are both instances of service copy engines.
    
    v2:
     - Rewrite / expand the commit message.  (Bala)
     - Fix checkpatch whitespace error.
    
    Bspec: 65019
    Cc: Lucas De Marchi <lucas.demarchi@intel.com>
    Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
    Reviewed-by: default avatarHaridhar Kalvala <haridhar.kalvala@intel.com>
    Link: https://lore.kernel.org/r/20230927205143.2695089-2-matthew.d.roper@intel.comSigned-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    1951dad5
xe_pci.c 20.9 KB