• Tobias Regnery's avatar
    usb: typec: ucsi: fix tracepoint related build error · 2f860691
    Tobias Regnery authored
    There is the following build error with CONFIG_TYPEC_UCSI=m, CONFIG_FTRACE=y
    and CONFIG_TRACING=n:
    
    ERROR: "__tracepoint_ucsi_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_register_port" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_notify" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_reset_ppm" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_run_command" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_ack" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    ERROR: "__tracepoint_ucsi_connector_change" [drivers/usb/typec/ucsi/typec_ucsi.ko] undefined!
    
    This compination is quite hard to create because CONFIG_TRACING gets selected
    only in rare cases without CONFIG_FTRACE.
    
    The build failure is caused by conditionally compiling trace.c depending on
    the wrong option CONFIG_FTRACE. Change this to depend on CONFIG_TRACING like
    other users of tracepoints do.
    
    Fixes: c1b0bc2d ("usb: typec: Add support for UCSI interface")
    Signed-off-by: default avatarTobias Regnery <tobias.regnery@gmail.com>
    Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2f860691
Makefile 214 Bytes