• Ed L. Cashin's avatar
    [PATCH] aoe: update documentation for udev users · 94955ede
    Ed L. Cashin authored
    Bodo Eggert <7eggert@gmx.de> writes:
    
    > Ed L Cashin <ecashin@coraid.com> wrote:
    >
    >> +if=A0test=A0-z=A0"$conf";=A0then
    >> +=A0=A0=A0=A0=A0=A0=A0=A0conf=3D"`find=A0/etc=A0-type=A0f=A0-name=A0udev=
    .conf=A02>=A0/dev/null`"
    >> +fi
    >> +if=A0test=A0-z=A0"$conf"=A0||=A0test=A0!=A0-r=A0$conf;=A0then
    >> +=A0=A0=A0=A0=A0=A0=A0=A0echo=A0"$me=A0Error:=A0could=A0not=A0find=A0rea=
    dable=A0udev.conf=A0in=A0/etc"=A01>&2
    >> +=A0=A0=A0=A0=A0=A0=A0=A0exit=A01
    >> +fi
    >
    > This will fail and print
    > ---
    > bash: test: etc/udev.conf: binary operator expected
    > ---
    > if there is more than one udev.conf.
    >
    > Fix: Always put quotes around variables.
    
    Thanks.  With the changes below, it still will complain if it finds
    more than one udev.conf, but only if /etc/udev/udev.conf doesn't
    exist.
    
    Quote all shell variables, and use /etc/udev/udev.conf if available.
    Signed-off-by: default avatarEd L. Cashin <ecashin@coraid.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    94955ede
udev-install.sh 714 Bytes