• Ville Syrjälä's avatar
    drm/i915: Fix DVO 2x clock enable on 830M · 1c4e0274
    Ville Syrjälä authored
    The spec says:
    "For the correct operation of the muxed DVO pins (GDEVSELB/ I2Cdata,
    GIRDBY/I2CClk) and (GFRAMEB/DVI_Data, GTRDYB/DVI_Clk): Bit 31
    (DPLL VCO Enable) and Bit 30 (2X Clock Enable) must be set to “1” in
    both the DPLL A Control Register (06014h-06017h) and DPLL B Control
    Register (06018h-0601Bh)."
    
    The pipe A and B force quirks take care of DPLL_VCO_ENABLE, so we
    just need a bit of special care to handle DPLL_DVO_2X_MODE.
    
    v2: Recompute num_dvo_pipes on the spot, use PIPE_A/PIPE_B instead
        of pipe/!pipe for the register offsets in disable (Daniel)
        Add a comment about the ordering in enable and another one
        about filtering out the DVO 2x bit in state readout
    Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Tested-by: Thomas Richter <richter@rus.uni-stuttgart.de> (v1)
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    1c4e0274
intel_display.c 380 KB