• Suraj Jitindar Singh's avatar
    powerpc: Add array bounds checking to crash_shutdown_handlers · 1d145165
    Suraj Jitindar Singh authored
    The array crash_shutdown_handles is an array of size CRASH_HANDLER_MAX+1
    containing up to CRASH_HANDLER_MAX shutdown_handlers. It is assumed to
    be NULL terminated, which it is under normal circumstances. Array
    accesses in the functions crash_shutdown_unregister() and
    default_machine_crash_shutdown() rely on this NULL termination property
    when traversing this list and don't protect again out of bounds accesses.
    If the NULL terminator were somehow overwritten these functions could
    potentially access out of the bounds of the array.
    
    Shrink the array to size CRASH_HANDLER_MAX and implement explicit array
    bounds checking when accessing the elements of the
    crash_shutdown_handles[] array in crash_shutdown_unregister() and
    default_machine_crash_shutdown().
    Signed-off-by: default avatarSuraj Jitindar Singh <sjitindarsingh@gmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    1d145165
crash.c 8.49 KB