• Akilesh Kailash's avatar
    dm snapshot: flush merged data before committing metadata · fcc42338
    Akilesh Kailash authored
    If the origin device has a volatile write-back cache and the following
    events occur:
    
    1: After finishing merge operation of one set of exceptions,
       merge_callback() is invoked.
    2: Update the metadata in COW device tracking the merge completion.
       This update to COW device is flushed cleanly.
    3: System crashes and the origin device's cache where the recent
       merge was completed has not been flushed.
    
    During the next cycle when we read the metadata from the COW device,
    we will skip reading those metadata whose merge was completed in
    step (1). This will lead to data loss/corruption.
    
    To address this, flush the origin device post merge IO before
    updating the metadata.
    
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarAkilesh Kailash <akailash@google.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    fcc42338
dm-snap.c 68.1 KB